search

Autodesk-Forge / library-javascript-viewer-extensions

A collection of various JavaScript extensions for the Forge viewer
MIT License
81 stars 48 forks source link

Markup3D Bugfix #6

Open 0x41mmar opened 6 years ago

0x41mmar commented 6 years ago

The latest update to Markup3D in this repository, before deprecation, is a bugfix in commit 0fbd12a, but somehow that fix breaks things for me. Everything works until I rotate the view, at which point I get a console error saying t.screenPoint undefined. I've tried using various versions, but the latest one that works is right before this commit.

Any idea what the issue could be? I'm using viewer version 3.3 (latest, I believe).

leefsmp commented 6 years ago

Can you try the version that is in that repo: https://github.com/Autodesk-Forge/forge-rcdb.nodejs/tree/master/src/client/viewer.components/Viewer.Extensions.Dynamic/Viewing.Extension.Markup3D

0x41mmar commented 6 years ago

Tried. Same issue occurs. What I'm doing is quite minimal, just loading bootstrap, jQuery, viewer and the extension, browsing straight from the file system. It seems the only possible source of error is my transpiling, but all I'm doing is an npm install and run build-prod.

leefsmp commented 6 years ago

I wrote recently a new markup feature based on PointCloud, which is much more performant when your app needs to handle large number of markups, you can take a look at those articles:

High-Performance 3D markups with PointCloud in the Forge Viewer

Using a Dynamic Texture inside Custom Shaders

The complete code is at: Viewing.Extension.PointCloudMarkup