Autodesk / Aurora

Real-time GPU path tracing with a USD Hydra render delegate
Apache License 2.0
474 stars 30 forks source link

Denoiser capabilities? Error on missing Denoiser.cpp/h #33

Open DanEnglesson opened 3 months ago

DanEnglesson commented 3 months ago

Hi,

Are there plans to add in denoise capabilities to this opensource repository? It looks like Aurora has that ability according to this video?

https://www.youtube.com/watch?v=8tDJn8ms-y8

And there are breadcrumbs to enable it in but getting stomped on the missing Denoiser.cpp and Denoiser.h files. https://github.com/Autodesk/Aurora/blob/3082b23dca4d549c93ff387a11dc955c3ee316b2/Scripts/installExternals.py#L1051 https://github.com/Autodesk/Aurora/blob/3082b23dca4d549c93ff387a11dc955c3ee316b2/Libraries/Aurora/CMakeLists.txt#L165

It would have been awesome to get this with denoising capabilities as it is a great interactive renderer and are curious to hear your thoughts on adding to this repository or if it is up to each consumer to add it separately.

Best Regards, Dan

pixnblox commented 3 months ago

We have denoising support internally based on NVIDIA NRD:

https://github.com/NVIDIAGameWorks/RayTracingDenoiser

You can see that operating in Autodesk Inventor. However, it relies on a version of NRD that predates their open source release, so we were not allowed to share that. We plan to update our integration to a more recent version that is open source. We could also host different denoisers if you have a different denoiser in mind.

DanEnglesson commented 3 months ago

Thanks for the quick response. That explains why the denoiser files were left out in the open-source repository. I think the NRD denoiser is the preferred one but being able to have multiple denoiser such as Intel's denoiser would be of interest too.

Good the hear that you are planning to integrate a more recent version of NRD that is open source. I just wanted to see if there was a plan to release an update to this or if it is something that the community could help develop.

Cheers, Dan