Reorder AppRole.map_val parameters

Autodesk / aomi

Provide secrets to build and release pipelines in a self service way using Hashicorp Vault.

https://autodesk.github.io/aomi/

MIT License

32 stars 13 forks source link

Reorder AppRole.map_val parameters #127

Closed skovorodkin closed 7 years ago

skovorodkin commented 7 years ago

AppRole.map_val is only used by AppRole.__init__, and the latter passes dest dict as the first argument, while map_val has src as the first parameter.

It makes sense to fix map_val signature and put dest on the first place. This way we change only one line and at the same time make it to follow traditions of some other languages.

I noticed it fixing https://github.com/Autodesk/aomi/pull/126, but haven't checked if it's really a bug yet.

TBU.

otakup0pe commented 7 years ago

Hmm this is part of the code which could really use some more test coverage... I'll take a look tonight...

skovorodkin commented 7 years ago

I haven't checked if it's really a bug yet.

I've just checked, and, yes, bug exists and this change fixes it.