Autodesk / hig

Autodesk's unified design system
https://storybook.weave.autodesk.com
Apache License 2.0
181 stars 114 forks source link

Proxy not defined errors in IE11 #1902

Open mcsmcs opened 5 years ago

mcsmcs commented 5 years ago

We leverage storybook, webdriver, and saucelabs to do visual regression testing. Recently, probably on a bump of theme-context or dependent components, we started getting errors when we run IE tests that have @hig/button@1.3.2 rendered.

The error is: Proxy is undefined

It looks like the Proxy feature is leveraged here: https://github.com/Autodesk/hig/blob/development/packages/theme-context/src/ThemeContext/createThemeProxy.js#L12

Unfortunately they're not supported in IE11: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy#Browser_compatibility

I'll try some runs with NODE_ENV === 'production' from here

But this could put other things into production mode (build tools) that aren't necessary, slowing down our tests. If the above works, can we consider leveraging a different environment variable (e.g. HIG_ENV)?

wmui51 commented 5 years ago

That is odd that you would be only encountering that now as Proxy has been part of Theme-Context for over 8 months now and all our components have been dependent on Theme-Context for a few months now as well.

I will add this issue to the backlog, thanks for reporting it.