Autodesk / hubble

🛰 Collaboration, usage, and health data visualization for GitHub Enterprise
https://autodesk.github.io/hubble
MIT License
176 stars 47 forks source link

New report for Failed Authentication and menu organization #223

Open toddocon opened 3 years ago

toddocon commented 3 years ago

I have a new report for 'Failed Authentication' similar to 'Failed Webhooks'. Looking at failed authentication attempts across the system is helpful in spotting misconfigured systems that may be tying up authentication workers. I often see this issue when someone changes their credentials but neglects to update stored credentials in their CI/CD systems which in turn causes lots of failed authentication attempts.

The number of reports on HOUSEKEEPING is getting larger. Before I create a PR for my change, should we consider making a submenu under HOUSEKEEPING for Failures and put both 'Failed Webhooks' and my new 'Failed Authentication' under this submenu (for organizational purposes)?

larsxschneider commented 3 years ago

That sounds like a great report, Todd! What do you think about a new main section called "Failure" or something?

toddocon commented 3 years ago

Hi Lars. I left a very lengthy comment and now it's gone. Hmm.

Anyways, what I had said was this is a great idea for a new main section.

Where would we like its position and what about the submenus?

Something like:

HOUSEKEEPING FAILURES RECOMMENDATIONS

Then the submenus I suggest that we don't need the text 'Failed' as in:

FAILURES 'Authentication' 'Webhooks'

vs

FAILURES 'Failed Authentication' 'Failed Webhooks'

We're already on the FAILURES section so the additional "Failed" menu text is redundant.