Autodesk / hubble

🛰 Collaboration, usage, and health data visualization for GitHub Enterprise
https://autodesk.github.io/hubble
MIT License
173 stars 49 forks source link

Add GHES 3.x compatibility #235

Closed stoe closed 2 years ago

stoe commented 2 years ago

Also addresses review comments in https://github.com/Autodesk/hubble/pull/228

stoe commented 2 years ago

@svasek, would love your feedback on this.

I've I've been approaching this the same way you did in #228, but added backwards compatibility checks.

toddocon commented 2 years ago

I just updated to 3.1.5 and am trying your changes in my environment.

I also notice that the Organizations > Owners report and Repositories > Size report are no longer working on 3.x.

svasek commented 2 years ago

I just updated to 3.1.5 and am trying your changes in my environment.

I also notice that the Organizations > Owners report and Repositories > Size report are no longer working on 3.x.

I found there is a problem with all reports based on ghe-console which executes code directly in rails console.

stoe commented 2 years ago

I found there is a problem with all reports based on ghe-console which executes code directly in rails console.

Good catch. I might have something to address that, but might not be able to get to it this week or next.

toddocon commented 2 years ago

You have a typo in failed-webhooks.sh. There is a ; missing before the then on line 19 as in:

if ghe_greater_equal "3.0.0"; then

After adding the ; I was able to get the script to work on my remote collection machine talking to GHES 3.1.5.

stoe commented 2 years ago

Close in favour of https://github.com/Autodesk/hubble/pull/246