Autodesk / maya-usd

A common USD (Universal Scene Description) plugin for Autodesk Maya
761 stars 202 forks source link

Early crashes in maya interactive tests marked as successes #911

Open pmolodo opened 3 years ago

pmolodo commented 3 years ago

Describe the issue Some types of maya problems will cause it to crash, before even executing any code (ie, -c command). In these cases, the exit code for maya will be 0, even if MAYA_NO_STANDALONE_ATEXIT is set, which means the test will be marked as a success.

Reproduction Steps The main difficulty is in trying to create a situation that will cause an early maya crash - in my case, it was triggered by adding a non-maya version of the PySide2 python libraries onto the PYTHONPATH.

Once this is done, if you just run any test that runs in INTERACTIVE mode - ie:

ctest -R testProxyShapeDrawColors

...then you will see maya crash, but the test will seem to succeed.

Possible Resolutions I think the exit code for GUI maya is simply too unreliable (and possibly for non-gui as well?) The most certain would be to switch to a mode where we assume tests are failed unless something indicating success if found - for instance, we could try to make tests write to a certain file, or somehow communicate with some other process...?

Specs:

kxl-adsk commented 3 years ago

Hidding fact that Maya crashed before we execute any test isn't very useful. The best would be to distinguish between test failure and Maya failure.

As for non-maya version of the PySide2 issue you mentioned - I asked around and it should be fixed in Maya 2020.3