search

Autodesk / molecular-simulation-tools

Web applications for molecular modeling using the Molecular Design Toolkit
http://molsim.bionano.autodesk.com
Apache License 2.0
16 stars 10 forks source link

Dynamic Steps #231

Closed justinmc closed 7 years ago

justinmc commented 7 years ago

This PR will be my first stab at generating the "tasks" steps seen numbered on the frontend dynamically, based on data passed from the server with the workflow. I'll try to limit the backend impact of this for now.

Issues https://github.com/Autodesk/molecular-simulation-tools/issues/204 and https://github.com/Autodesk/molecular-simulation-tools/issues/205

Waiting on https://github.com/Autodesk/molecular-simulation-tools/pull/228 and https://github.com/Autodesk/molecular-simulation-tools/pull/229

justinmc commented 7 years ago

@PeterRJones Check out the migration setup I wrote for this: https://github.com/Autodesk/molecular-simulation-tools/commit/1845cce2b1c59c947afa26aa7245b52fe4c539c6#diff-7cd651498ecb2e6d55bc2ea9aa2785e0R30

How do you normally handle db migrations? Is the production db nicely backed up in a way that we can roll back if these migrations destroy everything? It worked on my local db but I'm nervous :)

justinmc commented 7 years ago

@dionjwa Please take a look at this as a first step on the way towards using the dynamic app data that we've been discussing. I tried to add comments on the interesting parts since the PR is huge (due to renaming workflow to app everywhere). I left the name tasks as is since we didn't seem conclusive on a final name yesterday. Also notice that I'm purposely not yet using an intermediate VERIFY step for loading a PDB.

dionjwa commented 7 years ago

@justinmc This is too big with too many changes, about changes that are probably only partially done, for me to review this effectively. I'm going to merge, but you'll need to guide me through these current changes and the proposed changes.