search

Autodesk / molecular-simulation-tools

Web applications for molecular modeling using the Molecular Design Toolkit
http://molsim.bionano.autodesk.com
Apache License 2.0
16 stars 10 forks source link

Widget I/O Data #265

Closed justinmc closed 7 years ago

justinmc commented 7 years ago

Do not merge, WIP and waiting on https://github.com/Autodesk/molecular-simulation-tools/pull/263.

This PR adds inputs and outputs to app data and uses it to make widgets more generic. For example, the app now determines whether a widget is completed by looking at if it has created all of its output data.

The way that this PR stores "result" data from a widget is in the map at run.ioResults keyed on widget input/output ids. So the app looks at a widget's inputs or outputs and then looks up the actual result values in run.ioResults.

justinmc commented 7 years ago

This needs to be tested on the Results page. I can't now because runs are not completing.

I got around this by mocking the run endpoint for now. This is ok to get merged to master while we're in the middle of a big refactor. It will be deleted shortly when we move to CCC/CWL widgets.

justinmc commented 7 years ago

@dionjwa Just fixed your issues (renamed ios to pipes, ioResults to pipeDatas, and put a return after .then). Will plan to merge this after lunch.