justinmc
commented
7 years ago @dionjwa Let me know what you think about how I did the app json separation when you're back. I moved the app json into its own module in a root folder in the project. If we want to go through the process of creating a new open source repo, it should be very easy to move the folder there. For now I'm referring to the version of the json as specified in package.json, but if we move to a separate repo and wanted to specify git sha instead, that would also be just as easy.
Notice that I also got rid of all app data in redis and instead refer to apps directly from their static json on the server. The viewCount that was displayed on the homepage has been removed.
Lastly, Travis is giving me the error "TIRRENU_URL not specified", is that due to the same problem that Day was having?
Issue https://github.com/Autodesk/molecular-simulation-tools/issues/251
Waiting on https://github.com/Autodesk/molecular-simulation-tools/pull/265This PR will move app data into a separate location, remove all redis app data (including the dynamic
viewCount), and reference apps directly from the static json.It was mentioned that we might move the static json into a separate git repository. I'm currently not doing this as a part of this PR since it's a long process, but the folder where the apps json is could easily be moved into its own repo if it's necessary.