Autodesk / molecular-simulation-tools

Web applications for molecular modeling using the Molecular Design Toolkit
http://molsim.bionano.autodesk.com
Apache License 2.0
16 stars 10 forks source link

MST frontend dynamically creates apps from JSON specs #283

Closed justinmc closed 7 years ago

justinmc commented 7 years ago

Zube: https://zube.io/autodesk/genome-designer/c/1852

This represents our "parent" high level goal for the MVP push for MST. The app should generically generate an "app" from json, run its computes generically based on definitions in the json, and be deployable to production.

Initial work was done in this open PR and it will be used directly or indirectly as a feature branch for this: https://github.com/Autodesk/molecular-simulation-tools/pull/280

justinmc commented 7 years ago

The above issues are my initial idea of what it will take to get to MVP.

avirshup commented 7 years ago

@justinmc - will start posting questions here as I think of them. For now:

justinmc commented 7 years ago

@avirshup The app json is already being consumed by the frontend and used to generate our apps in master right now. The problem is that it's much simpler than our final specification is. Anything not included in that linked json is still hardcoded.

In my WIP PR I've already started adding complexity to the widget data. The main thing that's still missing for MVP is the ability to specify arbitrary docker images and commands for a widget to run, and for multiple RUN widgets to be supported.

The way that you would create a new app in json is to add it to the folder containing all the other apps and then include it in the main app js file.

Let me know if that doesn't answer your question!

avirshup commented 7 years ago

Yeah, that makes total sense. So the plan is to keep extending the app definitions in apps-data/apps/ as each of these linked issues gets completed?

justinmc commented 7 years ago

Yeah that's right. That app json is used as an npm module and could also easily be in a separate repo if needed.

justinmc commented 7 years ago

This is finished off and in master as of https://github.com/Autodesk/molecular-simulation-tools/pull/299!