Autodesk / molecule-2d-for-react

2D molecule visualization component
http://moldesign.bionano.autodesk.com/
Apache License 2.0
21 stars 12 forks source link

Split out nodes and links #2

Closed justinmc closed 8 years ago

justinmc commented 8 years ago

This PR is mainly an attempt at simplifying the architecture of the app by splitting out nodes and links from the main view into their own models and views. I'm trying to move toward a more data-bound approach, so I also got rid of at least one RPC call here.

I might do a bigger refactor or rewrite here at some point, but I'll save that until I know we have a good reason to.

justinmc commented 8 years ago

@avirshup Heads up that I'm opening this PR with the nbmolviz2d changes I showed you.

@maxbates Can you give me a quick code review? I think I'm forced to use backbone here for now, but I got this using the airbnb eslint and cleaned things up a bit at least.

maxbates commented 8 years ago

looks good to me!

justinmc commented 8 years ago

Thanks, merging!