search

Autodesk / molecule-2d-for-react

2D molecule visualization component
http://moldesign.bionano.autodesk.com/
Apache License 2.0
21 stars 12 forks source link

Replace D3? #9

Open justinmc opened 7 years ago

justinmc commented 7 years ago

D3 is really working against the idea of data binding that is core to this project. The only useful thing that D3 brings us is its force layout, which can be gotten from elsewhere.

justinmc commented 7 years ago

Another bug related to D3 is the slight jumping that happens whenever a selection is made, referenced in this nbmolviz issue: https://github.com/Autodesk/notebook-molecular-visualization/issues/32

This is due to pain messing with rerendering via D3 when data changes. It's probably fixable by keeping our current setup with D3, but I've already spent a ton of time tweaking that specific thing, and moving off of D3 would definitely get rid of that bug altogether.