search

Autodesk / notebook-molecular-visualization

2D and 3D molecular visualization in Jupyter notebooks using 3DMol.js and D3.js
http://moldesign.bionano.autodesk.com
Apache License 2.0
75 stars 20 forks source link

Abstract nbmolviz3d #9

Closed justinmc closed 8 years ago

justinmc commented 8 years ago

Like https://github.com/Autodesk/notebook-molecular-visualization/pull/6, will remove frontend code and move it to its own repo, but this time for nbmolviz3d.

Branched off of https://github.com/Autodesk/notebook-molecular-visualization/pull/6. Merged.

Do not merge, as https://github.com/Autodesk/notebook-molecular-visualization/pull/6 needs to go in first, and the npm module needs to be created and public.

Currently nbmolviz3d is separated here: https://git.autodesk.com/mccandj/nbmolviz3d. However, it will need to be made open source and published on npm. Here's the open source repo: https://github.com/Autodesk/nbmolviz3d and npm module: https://www.npmjs.com/package/nbmolviz3d

justinmc commented 8 years ago

Sorry for all the name changes, I was messing with a Github bug I found :)

justinmc commented 8 years ago

@avirshup Needs review please.

avirshup commented 8 years ago

@justinmc - looks good!

Only question - how were you envisioning dealing with the moldesign-examples directory here - Is it just a copy of the directory in molecular-design-toolkit/moldesign/_notebooks?

justinmc commented 8 years ago

@avirshup Good catch! I totally didn't mean to commit that directory. No wonder this diff is so big. I'll remove it.

justinmc commented 8 years ago

+188 - 26,038 much better. Sorry I made you review it with all that craziness in there :)

avirshup commented 8 years ago

That's some damn efficient code cleanup :)

avirshup commented 8 years ago

Oh and 👍 to merge