search

Autodesk / orion-ui

UI Components that work seamlessly in multiple UI frameworks
https://goo.gl/shxHPB
Other
22 stars 6 forks source link

Profile Flyout open/close setting not working #275

Closed shannonwells closed 7 years ago

shannonwells commented 7 years ago

Expected Behavior

  1. In the storybook, there is a "w Profile flyout open" story, which ought to render with the flyout open.
  2. Clicking on the storybook knob for this story to open and close Profile flyout should toggle open and close state of the Profile flyout.
  3. Clicking on the Profile itself should open the Profile flyout
  4. Clicking outside the Profile flyout should close the Profile flyout.

Current Behavior

1 and 2 do not work, but 3 and 4 do.

Debugging clues

preview.bundle.js:860 Warning: Failed prop type: Invalid prop `open` of type `string` supplied to `Profile`, expected `boolean`.
    in Profile

Which Orion version is affected?

I had thought this was working before I left but I don't know when it got broken. Current version of master, at latest 1.0.3-alpha.bf00eb54

shannonwells commented 7 years ago

This seems to have been fixed already.