Autodesk / revit-ifc

IFC for Revit and Navisworks (2019+)
486 stars 196 forks source link

ShapeAspect has a different name with its associated MaterialConstituent #517

Open h-iL opened 2 years ago

h-iL commented 2 years ago

From the BuildingSmart documentation, it suggests that using a MaterialConstituentname, we should be able to find its matching ShapeAspect.

image http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcShapeAspect.htm

However, from an Ifc file exported using Revit IFC 4 Reference View Architectural settings, there seems to be an issue with its naming, which makes it tricky while trying to retrieve its ShapeAspect. Greatly appreciate it if someone could help take a look at this :)

example of a naming error image

(please let me know if more info is required, or if attaching the ifc file here would be helpful)

AngelVelezSosa commented 2 years ago

@WawanSolihin?

WawanSolihin commented 2 years ago

The design of export with IfcShapeAspects and IfcMaterialConstituent is to match them, i.e. uses the same information (name) for both associated instances. To help us investigate the issue, could you share with us the Revit model and the IFC file that exhibit this reported issue?

h-iL commented 2 years ago

Thank you for looking into this @AngelVelezSosa @WawanSolihin. Absolutely! Please find attached revit and ifc file for reference. 01-WallCornerLayers.zip

WawanSolihin commented 2 years ago

Thanks. I will take a look and get back to you once I know the reason

WawanSolihin commented 2 years ago

There seems to be a bug in the export when there is material layer that has 0 thickness (which should be ignored), that gets included in naming the IfcShapeAspect. This causes inconsistency between the material constituent and the shapeaspect. I will log a defect into our system.

h-iL commented 2 years ago

Ahh.. Good to know..thanks @WawanSolihin! :)

h-iL commented 2 years ago

Hi @WawanSolihin @AngelVelezSosa I'm not sure this is a related issue, we have removed the 0mm membrane layer and made a new exported to ifc, but noticed that the ShapeAspect for the Gypsum Wall Board Facing - Fire Resistant wallboard seems incorrect, the layer should be 15mm, but the profile we get tracing from the named ShapeAspect has a thickness of 100mm

Would you mind take a look at this as well? Thank you :) 01-WallCorner(origin).zip

WawanSolihin commented 2 years ago

Sure I will add this into the bug report to be addressed together