Autodesk / sitoa

Arnold plugin for Softimage
Apache License 2.0
33 stars 16 forks source link

Add simple UI for noice denoiser #14

Closed caron closed 5 years ago

caron commented 6 years ago

We should have some sort of UI for the noice denoiser for non-technical users.

caron commented 6 years ago

Going to just copy this as closely as possible...

https://support.solidangle.com/display/A5AFMUG/Arnold+Denoiser

JenusL commented 6 years ago

Yeah we can probably grab a lot of the source directly from MtoA. https://trac.solidangle.com/mtoa/browser/mtoa/scripts/mtoa/denoise.py See the tickets associated with the commits as well for some info: 3461, 3459 and 3489

JenusL commented 6 years ago

There's also the issue of the variance AOV and filter required to denoise an image with noice. See MtoA ticket https://trac.solidangle.com/mtoa/ticket/3387

JenusL commented 5 years ago

The UI for noice is written in Python in MtoA. Do anyone see a problem if I also write it in Python so that most of the code can be copied, or should I rewrite it in JS like the other SItoA helpers?

sjannuz commented 5 years ago

No problem, thankyou

caron commented 5 years ago

Looks like this can be closed now with the merging of #53 and thanks @sjannuz for merging #29 to master