Autodesk / sitoa

Arnold plugin for Softimage
Apache License 2.0
33 stars 16 forks source link

Add Arnold to PATH #28

Closed JenusL closed 6 years ago

JenusL commented 6 years ago

So to fix the missing optix_denoiser.dll error I added the path to Arnold to PATH environment variable. It's adding the path on XSILoadPlugin and removing it again in XSIUnloadPlugin. This way we can reload SItoA as many times as we want without it filling the PATH with paths to Arnold. I only implemented it for Windows. This closes #8

caron commented 6 years ago

where any tests created with the annoying The specified module could not be found. messages? if so, do they need to be updated with this change?

JenusL commented 6 years ago

Good question. The last two tests (AOV Shaders and Toon shader) have the warning in their reference logs. But they still Passes so I wouldn't worry about it.

caron commented 6 years ago

gotcha, the images still pass the test... i will pull this into my local branch, compile, and test it on my machine tonight.

caron commented 6 years ago

ok, i compiled this and tested. thanks!