search

Autodesk / sitoa

Arnold plugin for Softimage
Apache License 2.0
33 stars 16 forks source link

Support OptiX denoising in display driver #48

Closed JenusL closed 5 years ago

JenusL commented 5 years ago

Basic support for OptiX denoising was added in #45. But one thing that doesn't work properly is the display driver. In MAXtoA there's a checkbox in Denoise tab to denoise the Beauty. We should add that as well. That way we don't need to add a RGBA_denoise or Main_denoise AOV and switch to that in the render region. Personally I would prefer if that checkbox only affected region renders as well so that you had to explicitly add Main_denoise to outputs if you want it to save to disk. Anyone agree with that?

JenusL commented 5 years ago

I've been occupied with Red Dead Redemption 2 for a few nights now but took a pause in the gaming and decided to have a look at this instead. Making the display driver take more than one output with AiDriverInitialize(node, true); makes this just work. It's amazing how robust this API is! I will clean up a bit and add the Denoise tab before I create a PR.