Autodesk / sitoa

Arnold plugin for Softimage
Apache License 2.0
33 stars 16 forks source link

New Arnold 5.1.0 shaders #6

Closed JenusL closed 6 years ago

JenusL commented 6 years ago

Added the following new shaders:

For toon to work properly I also added the new contour filter. While I was there I noticed that the sinc filter was missing so I added that as well.

Two new aovs for the toon shader is also added.

toon is outputting color instead of a closure so it couldn't be added to objects directly with AddShader() so I updated that function to handle non closure shaders as well.

caron commented 6 years ago

i find it curious (i haven't dug in myself just yet) that the toon shader is returning a color and not a closure.

JenusL commented 6 years ago

Both the node reference: https://support.solidangle.com/display/A5NodeRef/Toon and kick -info toon says output is RGB so nothing wrong there.

caron commented 6 years ago

oh, i don't question whether you're right but rather why that is from the dev/core side.

sjannuz commented 6 years ago

The previous merges introduced a conflict I see. One thing about toon, is that the lights, if any, must be referenced by name, so we'd need a button to translate a picked light into its SItoA name. I can check what I was doing before camera_projection turned the projection camera into a node (was a string in Arnold 4).

JenusL commented 6 years ago

Fixed the conflict.