search

Autodesk / sitoa

Arnold plugin for Softimage
Apache License 2.0
33 stars 16 forks source link

Can't inspect Material #65

Closed JenusL closed 5 years ago

JenusL commented 5 years ago

Looks like #40 introduced a nasty bug. It's impossible to inspect the Material node because it just jumps to standard_surface. This is because Material shows the closure PPG inside it. This makes it impossible to choose OpenGL settings like the texture to show in the viewport.

JenusL commented 5 years ago

So I thought I would loop through all open PPGs and only run InspectObj() if closure is main content. Application.Desktop.ActiveLayout.Views doesn't return any PPGs and I can't find any other way at all to get them. I've tried all I can think of but can't really find a solution to this other than to remove the code completely. @caron Any thoughts?

caron commented 5 years ago

Looking at it now...

caron commented 5 years ago

Hmm, this is tricky. Maybe we can inspect the material node also. InspectObj takes a string list so we can pass both the input and output of the closure node.

JenusL commented 5 years ago

Great thinking! So I just tried that and it doesn't work either :( It creates an infinite recursion because Material wants to show closure so the logic runs over and over.

caron commented 5 years ago

Right, doh! I am fine removing it, it was just a 'nice' thing to have. Don't want to cause trouble.

JenusL commented 5 years ago

Created a revert PR. I agree it was a nice thing to have. Maybe we can revisit it some time.