search

Autodesk / sitoa

Arnold plugin for Softimage
Apache License 2.0
33 stars 16 forks source link

Arnold 5.4.0 to master #80

Closed JenusL closed 4 years ago

JenusL commented 4 years ago

When 5.4.0 #76 and AdLM patch #79 is merged in to develop I think it's time to get this in to master and make a real release. We should test Linux first though.

sjannuz commented 4 years ago

@JenusL , I have a couple of build errors in linux, in particular this one:

plugins/sitoa/renderer/RenderInstance.cpp:234: error: 'std::thread' has not neen declared

JenusL commented 4 years ago

Ok so it seems the old GCC doesn't support that. I only use it to get number of threads. Is there any way in the Arnold API I can get the number of cores / threads? I have searched for it but didn't find any but maybe there's something undocumented?

sjannuz commented 4 years ago

What suggested here https://stackoverflow.com/questions/150355/programmatically-find-the-number-of-cores-on-a-machine seems to build fine. Unfortunately I can build but not test it. I'll upload the addon soon.

sjannuz commented 4 years ago

Are you ok with my changes @JenusL ?

JenusL commented 4 years ago

Yeah I'm fine with your changes :)

JenusL commented 4 years ago

@sjannuz If you can provide a build then maybe @knekke can test it a little bit? :)

sjannuz commented 4 years ago

For now I've uploaded the addons here: https://drive.google.com/drive/folders/1ZdXjsmJQKXl-VRSy_edSa17V1Kyry5Hm?usp=sharing

JenusL commented 4 years ago

@sjannuz Windows package seems to work fine but it doesn't have the AdLM patch applied. Any reason for that? @knekke Do you think you have time to test the Linux addon some time?

sjannuz commented 4 years ago

@sjannuz Windows package seems to work fine but it doesn't have the AdLM patch applied. Any reason for that?

My bad, I hadn't updated the build machine. I have now replaced the addon in the above location.

knekke commented 4 years ago

@JenusL It's running on Fedora. Just a very quick test though...

JenusL commented 4 years ago

Tried the new addon and patch is ok now. @knekke Thanks Thomas! So release?

sjannuz commented 4 years ago

@JenusL draft release ready, see https://github.com/Autodesk/sitoa/releases. Do you have some release notes ready to add ?

JenusL commented 4 years ago

@sjannuz Great! I can write some release notes now. Will post them soon.

JenusL commented 4 years ago

@sjannuz I don't think I have permission to see the draft release but here's a quick changelog i put together: https://gist.github.com/JenusL/f473d32fab463767e6b4a79b6dae1e7e

sjannuz commented 4 years ago

Released. Thankyou @JenusL for your passionate work.

JenusL commented 4 years ago

Add thank you @sjannuz for still supporting me :)