Autodesk / standard-surface

White paper describing the Autodesk Standard Surface shader.
Apache License 2.0
341 stars 25 forks source link

Unused sheen default value? #23

Open pablode opened 2 years ago

pablode commented 2 years ago

Hi! The spec describes a default value of 0.8 for the weight of the sheen BRDF: https://autodesk.github.io/standard-surface/#closures/sheen

However, in the implementations, the value is actually set to 0.0: https://github.com/Autodesk/standard-surface/blob/b34e081e0fdced603eaa87b1c2841f99986fde2e/reference/standard_surface.mtlx#L51 https://github.com/Autodesk/standard-surface/blob/b34e081e0fdced603eaa87b1c2841f99986fde2e/reference/standard_surface.osl#L177

Is this because the layer is optional and the input serves as both weight and toggle?