search

AutodeskRoboticsLab / Mimic

An open-source Maya plugin for controlling Industrial Robots. Written in Python 3.
https://www.mimicformaya.com/
172 stars 39 forks source link

Sample Rate in mPrefs is set as Int while it's a Float in main UI #34

Closed aatb-ch closed 2 years ago

aatb-ch commented 2 years ago

The Sample Rate setting is normally a Float input, so that when picking a sample rate in Seconds you set the interval with second units. It's currently an Int field in mPrefs which prevents to use custom intervals to sample at certain specific robot controller frequencies (eg 125Hz = 0.008s, 500Hz = 0.002s)

https://github.com/AutodeskRoboticsLab/Mimic/blob/7287c65a8b0d95f8b2212a1214c8cb28f0644430/mimic/scripts/mimic_prefs_ui.py#L356

https://github.com/AutodeskRoboticsLab/Mimic/blob/7287c65a8b0d95f8b2212a1214c8cb28f0644430/mimic/scripts/mimic_ui.py#L507

evanatherton commented 2 years ago

hmmm...I thought I fixed that. I must've only fixed the one in the main UI but not the prefs

Thanks for catching that - Will take a look!

evanatherton commented 2 years ago

Fixed :)

57e7119c7d6960181443eecd858d2554ed4fe7e8