search

Autodrop3d / serialTerminal.com

A browser based serial terminal. No plugins. Vanilla javascript.
https://www.serialterminal.com
ISC License
200 stars 46 forks source link

Enhance file structure #3

Closed ibram-reda closed 2 years ago

ibram-reda commented 3 years ago

changes

  1. separate code and style from markup and make index.html only contain HTML
  2. change serial Results Div to be auto scrollable
  3. change baud input to be baud selection
  4. add 5px padding to #LineToSend Input
  5. add check if the browser has no support for web serial Api before connection
mmiscool commented 3 years ago

While I am generally happy about splitting up a project to have better organisation on this particular one I really want to keep the source at less than 200 lines of code with comfortable amounts of white space for easy reading for the main example. That why I did it all in one HTML file.

Would you consider making the changes in a separate directory labeled "advanced"?

Also on my screen the CSS seems to make the height of the div for displaying data too tall and the page now scrolls on my screen rather than it being a clean non scrolling single page application.

I do plan to add a capability of shortcut buttons that the user can set up for custom strings to send as shortcuts. This is going to required that a more advanced version be put together and splitting it up in a more proper way would be required for that so the split up version would be great for that.

What is the reason to swap the baud input item to a select rather than the input with the data list. The input with the data list will allow the user to specify a non standard baud speed if need. Would rather not take away that capability of the user.

ibram-reda commented 3 years ago

Would you consider making the changes in a separate directory labeled "advanced"?

  • Instead of crating new directory Could you make another branch called dev or development and I will push in this branch ... and when you fell happy with the changes you can merge it with the master branch

I do plan to add a capability of shortcut buttons that the user

  • also I have some feature idea like multi device communication with connection ID /or naming ... if you like we can code together to add more features

What is the reason to swap the baud input item to a select

  • I was guessing that no need to use a non-standard speed, but I will change as what it was
mmiscool commented 3 years ago

The reason I asked for a new folder was because it is hosted using github pages and wanted to keep the home page simple but link to a more sophisticated version.