search

Automat-GH / minecrift

Modified version of Minecrift VR mod that focuses on the Vive and room scale VR
Other
115 stars 11 forks source link

Future of this project? #8

Open brycesub opened 8 years ago

brycesub commented 8 years ago

What is the future of this codebase? Will it be updated for 1.9? Will it be merged into mabrowning's codebase?

ionrover2 commented 8 years ago

From looking at the readme.md, there probably aren't any plans to merge this back into the minecrift mod. There hasn't been much activity on it and that mabrowning's fork was built for the oculus. He mentions that this was haphazardly thrown together to make it work so I doubt true integration is a top priority.

Automat-GH commented 8 years ago

It changes too many things and to merge cleanly back into the main branch. It also prioritizes room scale over seated, so would break things for Oculus users. Maybe a merge will get more interesting if the Rift gets high quality room scale support.

1.9 support is possible, though I noticed in the main branch that 1.8 support took quite a long time and Minecraft 1.9 was released before 1.8 VR support was finished. So maybe we pick a version that adds some good features and doesn't break mods too badly like 1.8 did.

StellaArtois commented 8 years ago

I'm tempted to port in the Oculus stuff into this repo, and continue from here to be honest. Once the Oculus Touch becomes available, it would definitely be worth merging the code bases again.

On 25 May 2016, at 18:13, Automat-GH notifications@github.com wrote:

It changes too many things and to merge cleanly back into the main branch. It also prioritizes room scale over seated, so would break things for Oculus users. Maybe a merge will get more interesting if the Rift gets high quality room scale support.

1.9 support is possible, though I noticed in the main branch that 1.8 support took quite a long time and Minecraft 1.9 was released before 1.8 VR support was finished. So maybe we pick a version that adds some good features and doesn't break mods too badly like 1.8 did.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

mabrowning commented 8 years ago

Is there undue harm in targeting OpenVR even for Oculus support? Who doesn't have Steam?

-Mark

On Wed, May 25, 2016 at 1:18 PM, StellaArtois notifications@github.com wrote:

I'm tempted to port in the Oculus stuff into this repo, and continue from here to be honest. Once the Oculus Touch becomes available, it would definitely be worth merging the code bases again.

On 25 May 2016, at 18:13, Automat-GH notifications@github.com wrote:

It changes too many things and to merge cleanly back into the main branch. It also prioritizes room scale over seated, so would break things for Oculus users. Maybe a merge will get more interesting if the Rift gets high quality room scale support.

1.9 support is possible, though I noticed in the main branch that 1.8 support took quite a long time and Minecraft 1.9 was released before 1.8 VR support was finished. So maybe we pick a version that adds some good features and doesn't break mods too badly like 1.8 did.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Automat-GH/minecrift/issues/8#issuecomment-221661018

StellaArtois commented 8 years ago

Agreed. And this repo already supports it.

On 25 May 2016, at 19:21, Mark Browning notifications@github.com wrote:

Is there undue harm in targeting OpenVR even for Oculus support? Who doesn't have Steam?

-Mark

On Wed, May 25, 2016 at 1:18 PM, StellaArtois notifications@github.com wrote:

I'm tempted to port in the Oculus stuff into this repo, and continue from here to be honest. Once the Oculus Touch becomes available, it would definitely be worth merging the code bases again.

On 25 May 2016, at 18:13, Automat-GH notifications@github.com wrote:

It changes too many things and to merge cleanly back into the main branch. It also prioritizes room scale over seated, so would break things for Oculus users. Maybe a merge will get more interesting if the Rift gets high quality room scale support.

1.9 support is possible, though I noticed in the main branch that 1.8 support took quite a long time and Minecraft 1.9 was released before 1.8 VR support was finished. So maybe we pick a version that adds some good features and doesn't break mods too badly like 1.8 did.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Automat-GH/minecrift/issues/8#issuecomment-221661018

— You are receiving this because you commented. Reply to this email directly or view it on GitHub

likwidtek commented 8 years ago

@Automat-GH are there any concerns about jrbudda's fork? Will those changes get folded in or is that just going to be a stand alone fork?

I don't know why he hasn't or if he intends to pull request.