search

AutomatedTester / browsermob-proxy-py

A python wrapper for Browsermob Proxy
http://oss.theautomatedtester.co.uk/browsermob-proxy-py
236 stars 104 forks source link

Adding option of using existing proxy port #36

Closed ncboodah closed 9 years ago

ncboodah commented 9 years ago

We have a long-running process with existing config we'd like to reuse so that we won't have to start up a new proxy with each run we make.

AutomatedTester commented 9 years ago

I agree with @aerickson for the key. existing_proxy_port_to_use would make the code more readable

ncboodah commented 9 years ago

Thanks for your feedback @AutomatedTester ! I have updated the commit to existing_proxy_port_to_use. Let me know if anything else needs to be changed.

AutomatedTester commented 9 years ago

landed in e5dc8cd

AutomatedTester commented 9 years ago

thanks for the patch!