Make sure the Java process is still running while waiting for the server to start

AutomatedTester / browsermob-proxy-py

A python wrapper for Browsermob Proxy

http://oss.theautomatedtester.co.uk/browsermob-proxy-py

236 stars 104 forks source link

Make sure the Java process is still running while waiting for the server to start #40

Closed onlywade closed 9 years ago

onlywade commented 9 years ago

I've noticed that when Server.start() is invoked and the Java process immediately fails (e.g. due to problems with the Java environment), the start() function continues waiting for the server to begin listening, until the ~30 second timeout expires.

It's no big deal in the grand scheme of things, but I thought it would be nice to have immediate feedback for the user in this case where the server is clearly not going to start.

AutomatedTester commented 9 years ago

landed in 7def089.

Thanks for the patch and sorry it took so long to merge.