search

AutomatedTester / browsermob-proxy-py

A python wrapper for Browsermob Proxy
http://oss.theautomatedtester.co.uk/browsermob-proxy-py
236 stars 104 forks source link

feature: pass title at har page creation #48

Closed nicolasunravel closed 8 years ago

nicolasunravel commented 8 years ago

this time with atomic commits, and proper messages

nicolasunravel commented 8 years ago

don't know why tests failed, bmp init issue on the CI ?

AutomatedTester commented 8 years ago

I have gone through and made some fixes for some tests (because I had been lazy). If you rebase and they still fail, let me know and I will have a gander.

Thanks again for the patch!

David

David Burns Email: david.burns@theautomatedtester.co.uk URL: http://www.theautomatedtester.co.uk/

On Thu, Mar 31, 2016 at 11:08 AM, Nicolas notifications@github.com wrote:

don't know why tests failed, bmp init issue on the CI ?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/AutomatedTester/browsermob-proxy-py/pull/48#issuecomment-203863216

alan-unravel commented 8 years ago

Hi, @nicolasunravel is OOF for the next while and he asked me to throw an eye on this. He rebased as far as I am aware and the CI seems to fail but I am unsure of how to resolve this.

AutomatedTester commented 8 years ago

@alan-unravel Looking at the errors, the rebase didnt work. I will rebase/cherry-pick for you now. I also have the tests passing locally.

AutomatedTester commented 8 years ago

landed in cfda250, b748e8e, 9840668, 728dd46

AutomatedTester commented 8 years ago

thanks for the patch!