search

AutomationD / esp-alt-sdk

❌This repo is not maintained anymore❌
20 stars 6 forks source link

- Some adaptations for gcc-4.9.2 and Cygwin #8

Closed Juppit closed 8 years ago

Juppit commented 8 years ago
AutomationD commented 8 years ago

@Juppit looks like you have a lot of nonrelated changes. Can you please pull latest and update the PR to reflect only ones that are for gcc-4.9.2?

We can also add style changes (indents, remove comments,etc) later, in a different PR.

For me it sounds like it should be 2 things to add:

Or did I miss anything?

Juppit commented 8 years ago

The changes for 4.9.2 are more trivial. I will try that, but in these days, time is rare! ;-)

Am 23.12.2015 um 01:52 schrieb Dmitry Kireev:

looks like you have a lot of nonrelated changes. Can you please pull latest and update the PR to reflect only ones that are for gcc-4.9.2?

We can also add style changes (indents, remove comments,etc) later, in a different PR.

— Reply to this email directly or view it on GitHub https://github.com/kireevco/esp-alt-sdk/pull/8#issuecomment-166770166.

AutomationD commented 8 years ago

@Juppit I incorporated your changes in #12 Thank you very much for your contribution.

There are binary builds available for test here https://bintray.com/kireevco/generic/xtensa-lx106-elf/view#files (v4.9.2)

Let's test it for some time and merge this PR.