Closed ParaskP7 closed 1 year ago
Awesome @oguzkocer , thanks for adding JDK17 support to this repo, then reviewing and tentatively approving the changes, pending some extra testing! 🙇 ❤️ 🚀
FYI: I went ahead, marked this PR as Ready for review
and removed the [PR] Not Ready for Merge
label. The last nice to have
thing for us to do is to coordinate the merge wit with all the other library and client PRs, merging this PR only when every other such PR is ready to be merged as well.
Thanks for updating the publish-to-s3
Gradle plugin @oguzkocer , LGTM, you rock! 🙇 ❤️ 🚀
Platform Request:
pdnsEh-13V-p2
Project Thread:paaHJt-57Z-p2
This PR upgraded Gradle to 8.2.1 and AGP to 8.0.2.
PS: This Gradle and AGP upgrade was done in order to align this repo with the rest of such WordPress-Mobile Android library related repos. However, mind the fact that this work here is not necessary to complete the aforementioned project, just some extra work to help with the wider alignment efforts.
🚫 Blocked By:
Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
CI Failure
``` [2023-07-18T13:04:04Z] FAILURE: Build failed with an exception. -- | [2023-07-18T13:04:04Z] | [2023-07-18T13:04:04Z] * Where: | [2023-07-18T13:04:04Z] Build file '/var/lib/buildkite-agent/builds/ci-android-i-098082138775f5d9d-1/automattic/automattic-tracks-android/AutomatticTracks/build.gradle' line: 2 | [2023-07-18T13:04:04Z] | [2023-07-18T13:04:04Z] * What went wrong: | [2023-07-18T13:04:04Z] An exception occurred applying plugin request [id: 'com.android.library', version: '8.0.2'] | [2023-07-18T13:04:04Z] > Failed to apply plugin 'com.android.internal.library'. | [2023-07-18T13:04:04Z] > Android Gradle plugin requires Java 17 to run. You are currently using Java 11. | [2023-07-18T13:04:04Z] Your current JDK is located in /usr/lib/jvm/java-11-openjdk-11.0.19.0.7-1.amzn2.0.1.x86_64 | [2023-07-18T13:04:04Z] You can try some of the following options: | [2023-07-18T13:04:04Z] - changing the IDE settings. | [2023-07-18T13:04:04Z] - changing the JAVA_HOME environment variable. | [2023-07-18T13:04:04Z] - changing `org.gradle.java.home` in `gradle.properties`. ```Breaking Change List:
AGP Upgrade Assistant List:
Gradle Configuration List:
Lint Configuration List:
Dependency Versions Refactor List:
Associated clients (
N/A
)FYI:
Automattic-Tracks-Android
is not part of a composite build, neither forWPAndroid
,WCAndroid
clients or theFluxC
library.To test:
./gradlew build
locally and verify that it is successful (see previous such update).Merge instructions
Ready for review
.[PR] Not Ready for Merge
label.wellsql
is not part of a composite build.