Add macOS support for ExPlat

Automattic / Automattic-Tracks-iOS

Client library for tracking user events for later analysis

GNU General Public License v2.0

42 stars 12 forks source link

Add macOS support for ExPlat #164

Closed jkmassel closed 3 years ago

jkmassel commented 3 years ago

While working on #159 I noticed that the ABTesting code wasn't targeting macOS. Because we want to keep this library in sync across both platforms, this PR just runs around and adds everything to the macOS target as well – it was pretty much all already compatible! 😅

To Test:

Note that we're now running the ExPlat tests with our macOS tests
Note that the tests pass!

jkmassel commented 3 years ago

I guess we can remove the last exclude path from this line

Yeah, good call thanks!!

jkmassel commented 3 years ago

So after trying that, there's a problem with updating to macOS 10.12 (because it starts building for arm64 at that point, which isn't supported by Sentry).

We'll need to land #159 first, then remove that chunk of the podspec.

To avoid conflicts, I'll merge this for now and fix up the podspec once that work is done if that's ok?