search

Automattic / Automattic-Tracks-iOS

Client library for tracking user events for later analysis
GNU General Public License v2.0
41 stars 12 forks source link

Add support for Sentry performance monitoring #220

Closed mokagio closed 1 year ago

mokagio commented 2 years ago

Version 7.0 introduced performance monitoring. To prove the upgrade was successful, visit the performance page for the demo app:

image

I also checked that reporting still works. The screenshot below shows events I sent via the Tracks Demo iOS app:

image

Notice the UTC timestamp in Sentry and the AEST time in my macOS clock.

You can also see the individual events here:

mokagio commented 2 years ago

@crazytonyli @jkmassel this is ready for review but I'm leaving it a draft so I don't accidentally merge it.

The reason I'm doing this is because I'm keen to hear your thoughts on the version number to use.

My changes a breaking, because of the new property in CrashLoggingDataProvider (case in point for it being a struct where we can have default values in cases like this, as per #221). If this library was at version 1.x or later, SemVer would require us to ship a new major version. But we're still at 0.x so we have no explicit obligation not to ship breaking changes...

Should we take this as a chance to ship version 1.0? @jkmassel you likely have more background knowledge on this.

cc @jaclync @rachelmcr, you worked on the library recently, too, and might have thoughts on this.

mokagio commented 1 year ago

@crazytonyli @jkmassel this is officially ready for review. Thanks!

The macOS test may or may not be still failing by the time you read this. More details in #217 .