Automattic / Automattic-Tracks-iOS

Client library for tracking user events for later analysis
GNU General Public License v2.0
43 stars 12 forks source link

Does `CrashLoggingDataProvider` need to exist as a `protocol`? #221

Open mokagio opened 2 years ago

mokagio commented 2 years ago

While working on #220, I was surprised to see CrashLoggingDataProvider as a protocol when the role it has in the code is that of a value type carrying configuration values.

If there's no external constraint on it being a protocol, I propose to convert it into a struct.

Having it as a struct would mean clients can create an instance directly, without the cruft of implementing a custom type conforming to it.