Automattic / Automattic-Tracks-iOS

Client library for tracking user events for later analysis
GNU General Public License v2.0
43 stars 12 forks source link

Add options to config Sentry app hang and HTTP client error tracking #261

Closed itsmeichigo closed 1 year ago

itsmeichigo commented 1 year ago

Part of https://github.com/woocommerce/woocommerce-ios/issues/10372

Description

Since Sentry v8.0.0, app hang and HTTP client errors are tracked by default. These reports overflow the issue list for WCiOS, so we want to add an option to disable these tracking from our side.

This PR adds new options for CrashLoggingDataProvider: enableAppHangTracking and enableCaptureFailedRequests. These are used to configure relevant Sentry options. They are kept as ~true~ false by default ~not to affect any existing apps using this dependency~ and other apps can opt in if needed.


itsmeichigo commented 1 year ago

@mokagio I'm setting the new version with 2.3.0 as we are not planning to ship a new version soon for this library. I'm still confused about the versioning since the last update of WordPressUI, so pinging you to make sure that this is ok.

itsmeichigo commented 1 year ago

@mokagio I merged the change, could you help with the release, please? 🙇 Edited: I created a release for 2.3.0 myself but couldn't trigger CI to push a new version of the library on Cocoapods. I'll proceed to merge the WCiOS PR pointing to trunk of this library for now.

mokagio commented 1 year ago

@itsmeichigo 👍 👍 👍