search

Automattic / Automattic-Tracks-iOS

Client library for tracking user events for later analysis
GNU General Public License v2.0
42 stars 12 forks source link

De-duping common properties not working right #61

Closed astralbodies closed 1 year ago

astralbodies commented 7 years ago

It appears that there are properties not being detected as shared across all events being sent and not included in the common props dictionary. For example things like _ul and dotcom_user should be in common props:


2017-01-11 07:25:50.524 WordPress[64252:4182300] Sending Tracks data: {
    commonProps =     {
        "_ht" = 667;
        "_lg" = "en_US";
        "_rt" = 1484141150524;
        "_via_ua" = "Nosara Client for iOS 0.1.2";
        "_wd" = 375;
        "device_info_app_name" = WordPress;
        "device_info_app_version" = "6.8";
        "device_info_app_version_code" = "6.8.0.1";
        "device_info_brand" = Apple;
        "device_info_current_network_operator" = Unknown;
        "device_info_manufacturer" = Apple;
        "device_info_model" = Simulator;
        "device_info_os" = iOS;
        "device_info_os_version" = "10.2";
        "device_info_phone_radio_type" = Unknown;
        "device_info_wifi_connected" = YES;
    };
    events =     (
                {
            "_en" = "wpios_my_site_tab_accessed";
            "_ts" = 1484141135499;
            "_ui" = "";
            "_ul" = ardwptest1;
            "_ut" = "wpcom:user_id";
            "accessibility_voice_over_enabled" = 0;
            "device_info_wifi_connected" = NO;
            "dotcom_user" = 1;
            "jetpack_user" = 0;
            "number_of_blogs" = 2;
            platform = iOS;
        },
                {
            "_en" = "wpios_application_installed";
            "_ts" = 1484141135523;
            "_ui" = "";
            "_ul" = ardwptest1;
            "_ut" = "wpcom:user_id";
            "accessibility_voice_over_enabled" = 0;
            "device_info_wifi_connected" = NO;
            "dotcom_user" = 1;
            "jetpack_user" = 0;
            "number_of_blogs" = 2;
            platform = iOS;
        },
                {
            "_en" = "wpios_application_opened";
            "_ts" = 1484141135525;
            "_ui" = "";
            "_ul" = ardwptest1;
            "_ut" = "wpcom:user_id";
            "accessibility_voice_over_enabled" = 0;
            "device_info_wifi_connected" = NO;
            "dotcom_user" = 1;
            "jetpack_user" = 0;
            "number_of_blogs" = 2;
            platform = iOS;
        }
    );
}```