Automattic / Automattic-Tracks-iOS

Client library for tracking user events for later analysis
GNU General Public License v2.0
43 stars 12 forks source link

Retain cycles in tracks client #65

Closed koke closed 6 years ago

koke commented 7 years ago

We've identified a couple of retain cycles which prevent the TracksService to be deallocated when it's not needed anymore. This has the side effect of sending queued events after the service is already released from the app.

Both the service and the remote reference self from a callback block without __weak:

screen shot 2017-07-07 at 11 17 29 screen shot 2017-07-07 at 11 19 40