Automattic / Co-Authors-Plus

Multiple bylines and Guest Authors for WordPress
https://wordpress.org/plugins/co-authors-plus/
GNU General Public License v2.0
290 stars 205 forks source link

CoAuthors Plus & Elementor Archive Pages conflict. #905

Closed mattpramschufer closed 1 year ago

mattpramschufer commented 1 year ago

We have a sidebar global template in Elementor, it has a Posts widget that has the Author meta data shown. This works great on ALL pages EXCEPT author archive templates. When viewing the author archive the post widget takes the author name of the author archive rather than then post author on the widget block.

https://s3.amazonaws.com/pramadillo/co-authors1.jpg https://s3.amazonaws.com/pramadillo/coauthors-2.jpg https://s3.amazonaws.com/pramadillo/co-authors3.jpg

I have created a support ticket with Elementor and was escalated to their tier 3 support which then indicated that the error resides in the CoAuthors Plus plugin and not within Elementor. Their response was

On Wed, Dec 14, 2022 at 1:46 PM help@support.elementor.com wrote: Hello there,

I appreciate your patience. I have received feedback from Tier 3.

They said that it is a plugin incompatibility with Co-Authors Plus. We created an incompatibility report, but I recommend you report this issue to the Co-Authors Plus support as well. So they can inspect this further.

If you have any more questions, feel free to email me back.

Kind regards,

mattpramschufer commented 1 year ago

Any insight on this at all?

mattpramschufer commented 1 year ago

This is a direct result of the public function fix_author_page( $selection ) {

You are making the author of every post on the author archive page be whatever the query_var author_name equals. Which that is always going to be whichever author of the archive you are looking at. I have submitted PR #926 which corrects the issue.

GaryJones commented 1 year ago

Closed in https://github.com/Automattic/Co-Authors-Plus/pull/926.