Automattic / Edit-Flow

WordPress plugin to accelerate your editorial workflow
https://editflow.org
359 stars 132 forks source link

Suggestion: Implement git-flow on this repo #339

Closed robertsky closed 8 years ago

robertsky commented 8 years ago

If it is possible, can we implement git-flow on this repo? http://nvie.com/posts/a-successful-git-branching-model/

In this manner:

Hotfix and feature branches are superfluous here, in my opinion, since most of us are contributing by forking and submitting pull requests. Just need to label the branches proper, and that may do.

I am more concerned with master and release branches here as this will aid in pushing out new translatable strings to GlotPress (as I had mentioned in #335) and as well as giving the site administrators an option to test a beta release (release branch) and feed back to the team here that there are issues, if any, before the stable version is pushed out.

cojennin commented 8 years ago

Definitely an interesting idea. A couple of thoughts:

mjangda commented 8 years ago

This project did use git-flow in the early days; there were many issues with it (which @cojennin noted).

cojennin commented 8 years ago

@robertsky did you have any further thoughts you wanted to add? Going to punt on using git-flow for the moment, but wanted to make sure you had a chance to respond. You made some interesting points and if we reopen this down the road I want to make sure we collected them all.

cojennin commented 8 years ago

@robertsky going to close this for the time being. As I mentioned above, we can revisit this idea if we find the current Git workflow unsuitable. Thanks for input!