Closed alecgeatches closed 6 months ago
End to end tests are now passing! See the last run: https://github.com/Automattic/Edit-Flow/actions/runs/9165713334/job/25199719325
The lint-js
task has been moved to run after jest and end-to-end tests. We'll come back to address the tons of linting warnings and errors very soon.
Hello @rebeccahum! We're doing some refactorings starting with fixing end-to-end tests in GitHub Actions and a PHP version bump. Please take a look! We'll plan to do a new plugin release once we're done with modernization work.
@ingeniumed I'm going to merge this into a new develop
branch. Thank you!
As a first step for modernization, this PR:
7.4
, and removes testing for lower versions..nvmrc
to mark the node version of14
. We'll want to move this to a modern version (20
) soon.eslines
fromnpm lint-js
.eslines
is an Automattic utility that seemed to be used to ignore linting errors also in themaster
branch, but was throwing errors and blocking tests. As it's close to 3 years out of date, I just dropped the usage and allowedeslint
tests to fail. We'll come back to these very soon to--fix
, ignore, and manually fix the remaining errors.