Closed ingeniumed closed 4 months ago
Left one small comment about VIP detection for
vip dev-env
, and I also see there are some PHPCS errors from the tests. Other than that, looks good to me! Glad we're getting a lot of the PHPCS formatting out of the way, because it's a lot to review and GitHub's diffing is not equipped to review this many file changes.
I ended up disabling that script for now. I figured once we lint the entire codebase we can renable it just so we don't keep getting failures. It makes sense it would fail though because linting custom status causes aboutg 1500 lines to change and that can be pushed off to another PR
Description
timesince
because it's not used and it's not really do proper GMT calculations. The old code that it used to be used for has been replaced by human_time which is way simpler. Didn't really think marking this as deprecated and pointing to that is better. We will encounter more cases like this and we can make a call case by case.Steps to Test