search

Automattic / Gravatar-SDK-Android

Gravatar Android library
https://gravatar.com
Mozilla Public License 2.0
45 stars 11 forks source link

QuickEditor: Downsize uploaded image #305

Closed AdamGrzybkowski closed 1 month ago

AdamGrzybkowski commented 2 months ago

There's a bug in UCrop that cause the cropped images to keep their original file size.

The PR with a fix is open but it seems unlikely we can get it merged.

AdamGrzybkowski commented 2 months ago

@maxme It looks like we will have to go with the fork. Do you want to use the WP one, or create a new one?

maxme commented 2 months ago

Do you want to use the WP one, or create a new one?

The WP one is not used. WPAndroid uses the official version now (v2.2.9), the repo should be closed or deprecated.

IMO we should create a new one, forking the official repo under the automattic/ group. If we have to keep it, and eventually if WPAndroid also needs this fork, I think it's better if its under automattic. What do you think about it?

AdamGrzybkowski commented 2 months ago

What do you think about it?

Sounds good.

AdamGrzybkowski commented 2 months ago

@wzieba What would be the best way to have our fork version released?

wzieba commented 2 months ago

I think our ~local~ own instance of S3 would be fine. At the same time, it'd be maybe nice to offer this on Maven Central, so the open source community can benefit from your fix from a trusted repository.