Automattic / Gravatar-SDK-Android

Gravatar Android library
https://gravatar.com
Mozilla Public License 2.0
44 stars 11 forks source link

Throwing GravatarException on noncatching service methods #392

Closed hamorillo closed 2 weeks ago

hamorillo commented 2 weeks ago

Closes #377

Description

We want to wrap all exceptions that can occur inside the Gravatar service methods in our own GravatarException to provide the ErrorType as we do in the catching variants of those methods.

With this approach, we'll provide detailed information about the error, but at the same time, third-party developers know what exceptions can be expected from the Gravatar Services, basically GravatarException.

Testing Steps

wpmobilebot commented 2 weeks ago
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App Name Gravatar Demo
Commit1976a412314c358c30ce325418c1153677a40776
Direct Downloadgravatar-demo-prototype-build-pr392-1976a41.apk