search

Automattic / Gravatar-SDK-Android

Gravatar Android library
https://gravatar.com
Mozilla Public License 2.0
44 stars 11 forks source link

Make onDismiss optional in the GravatarQuickEditor.show() #396

Closed AdamGrzybkowski closed 2 weeks ago

AdamGrzybkowski commented 2 weeks ago

Description

Small public API update. The onDismiss callback can be ignored, as it's not critical to QE functioning, so I made it optional and added the @JvmOverloads for Java interop.

I noticed we had an outdated doc comment for this callback so updated it as well.

Testing Steps

Smoke test QE from the XML Activity class

wpmobilebot commented 2 weeks ago
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App Name Gravatar Demo
Commit9249f674d8fe113a247c5b4465037e372b3b61f0
Direct Downloadgravatar-demo-prototype-build-pr396-9249f67.apk