search

Automattic / Gravatar-SDK-Android

Gravatar Android library
https://gravatar.com
Mozilla Public License 2.0
44 stars 11 forks source link

Create an empty GravatarUCropActivity to avoid Manifest merger fails #398

Closed AdamGrzybkowski closed 2 weeks ago

AdamGrzybkowski commented 2 weeks ago

Description

When a third-party app depends on UCrop already they likely have defined the UCropActivity in the manifest. We do that as well in the QE and this causes the Manifest merger to fail.

It's possible to remove that declaration from a third-party app (or use tools:replace) and keep the one from QE, but it's not ideal because there could be custom fields set that could differ from the ones we use.

To fix this I've added a "fake" UCrop activity to not have clashing names. This way we can define our Activity in the manifest without requiring third-party apps to remove theirs.

Testing Steps

I've added a potentially conflicting UCropActivity to the demo app, so the CI should be enough.

I was also able to confirm this in the WP app with the built from this PR.

wpmobilebot commented 2 weeks ago
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App Name Gravatar Demo
Commitb282cb44741cdc68e138c4f8036e1e15eddfeeb3
Direct Downloadgravatar-demo-prototype-build-pr398-b282cb4.apk