Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
36 stars 1 forks source link

using-openapi-generator-swift5 #249

Closed etoledom closed 3 months ago

etoledom commented 4 months ago

This is an alternative to https://github.com/Automattic/Gravatar-SDK-iOS/pull/248

On this PR we use https://openapi-generator.tech/docs/generators/swift5/ instead of https://github.com/apple/swift-openapi-generator .

Benefits over Apple's generator:

Drawbacks over Apple's generator:

On this example, I opted for having Profile public, I'm not very happy with this, but the extra boilerplate of wrapping it in a different struct seems unnecessary now, keeping in mind that we can have control (or at least a vote) on yaml spec changes (up to debate).

Testing Steps

etoledom commented 3 months ago

@pinarol - I believe this is ready for review 👍