Update ProfileServiceError & Cleanup ProfileService - Githubissues

Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.

https://gravatar.com

Mozilla Public License 2.0

36 stars 1 forks source link

Update ProfileServiceError & Cleanup ProfileService #271

Closed pinarol closed 3 months ago

pinarol commented 3 months ago

Closes #266

Description

Updates these things in ProfileService:

Updated ProfileServiceError to APIError, since it applies to all potential REST calls not just to the ProfileService.
Replaced "noProfileInResponse" with "decodingError".
Removed some unnecessary and buggy result mapping code from ProfileService.
Removed the compilation handler method in the ProfileService. Just for sake of less code.
Added some unit tests for error cases.

Testing Steps

Demo app > Fetch Profile