Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
41 stars 5 forks source link

Use Rsync instead of CP for copying generated source files #323

Closed andrewdmontgomery closed 3 months ago

andrewdmontgomery commented 3 months ago

Closes #

Description

This does a few things:

Rsync instead of CP

If we ever remove (or rename) a model, the cp command will copy the new source file. But it will leave the old source file in place. This rsync command will --delete any files in the destination that are not present in the source.

Testing Steps

andrewdmontgomery commented 3 months ago

Technically, since we commit the model files, we do generate documentation for those types. See Profile as an example.

Goodness. I must have been tired at the end of the week when I went looking for those models. You are totally right.

My guess is that these generated docs are useful when the generated files are not committed in source control.

Absolutely. I'll remove all that extra stuff.

Update the make generate command to use rsync instead of cp Totally let's do this 🎉

And yep, I'll make this PR just this.

andrewdmontgomery commented 3 months ago

@etoledom I changed the name of this PR to reflect the more limited scope.

etoledom commented 3 months ago

I've just updated from trunk to make this PR mergable