Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
36 stars 1 forks source link

Rename `Gravatar-Demo` --> `UIKit-Demo`, `Gravatar-SwiftUI-Demo` --> `SwiftUI-Demo` #327

Closed andrewdmontgomery closed 1 month ago

andrewdmontgomery commented 1 month ago

Closes #

Description

This makes a few changes in preparation for being able to publish Prototype builds of our Swift and SwiftUI demo apps. It also adds separate AppIcons for each target.

Note that this also updates the bundleId's so that they can be easily distinguished and mapped to the appropriate targets.

It also corrects a filename error:

- Gravatar-SwiftUI-Demo.Base.xcconfig.xcconfig
+ Gravatar-SwiftUI-Demo.Base.xcconfig

Edit: I ended up renaming the xcconfigs to match the Scheme names.

Testing Steps

andrewdmontgomery commented 1 month ago

@etoledom @pinarol

mokagio commented 1 month ago

Have you considered renaming the folders as well? I think if the rename is dove via Xcode, all the reference in the project file will update automatically.

@andrewdmontgomery I'm going to merge this as is so there won't be conflicts when I'll edit the xcconfigs later.

The folder rename can happen later, if agreed. And I'd be happy to do it myself while I'm in that part of the code.

andrewdmontgomery commented 1 month ago

Thanks @mokagio . I'll address your question about folders in the main PR.