Update target/scheme names

Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.

https://gravatar.com

Mozilla Public License 2.0

41 stars 5 forks source link

Update target/scheme names #329

Closed andrewdmontgomery closed 3 months ago

andrewdmontgomery commented 3 months ago

Closes #

Description

This updates the target names and the scheme names:

Update target names so that they reflect the product names they will be used to generate
Update the scheme names to match
Update .xcconfig file names to match the scheme/folder names

Since the name for schemes and folders can be more verbose, I've chosen to keep the Gravtar- prefix. This has the added benefit of matching the existing folder names for each demo app.

Screenshot 2024-07-25 at 11 06 37 AM

Testing Steps

[ ] Build (and run) demos in Xcode
[ ] Build demos from command line make build-demo (this will build both)

etoledom commented 3 months ago

@etoledom Can you also check?

I agree. Display Name only affects the name under the icon, right? It would be nice to not have a dash there 🙏

pinarol commented 3 months ago

Display Name only affects the name under the icon, right?

Yep.

andrewdmontgomery commented 3 months ago

Yeah, I like it with the space, too.

And there's no reason a target can't have a space.

And having the target name be slightly different from the product name adds unnecessary complication.

I'll update the target names to replace the - with a space.

andrewdmontgomery commented 3 months ago

I resolved the project file conflicts from the target branch, and then made the change. Looks excellent.

iPhone SE (3rd Generation)	iPhone 15 Pro Max